Wizard: let logged-out users browse and build official images - #4736
Closed
lucasgarfield wants to merge 4 commits into
Closed
Wizard: let logged-out users browse and build official images#4736lucasgarfield wants to merge 4 commits into
lucasgarfield wants to merge 4 commits into
Conversation
lucasgarfield
requested review from
ksiekl,
mgold1234 and
regexowl
and removed request for
a team
August 10, 2026 17:53
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
lucasgarfield
force-pushed
the
lucas/cockpit/3-official-images
branch
from
August 10, 2026 18:17
43dbf23 to
c64c16e
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
lucasgarfield
changed the base branch from
lucas/cockpit/1-dev-registry
to
lucas/cockpit/2-local-images
August 10, 2026 18:18
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## lucas/cockpit/2-local-images #4736 +/- ##
================================================================
+ Coverage 78.20% 78.98% +0.77%
================================================================
Files 264 264
Lines 7021 7033 +12
Branches 2542 2548 +6
================================================================
+ Hits 5491 5555 +64
+ Misses 1437 1381 -56
- Partials 93 97 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
lucasgarfield
force-pushed
the
lucas/cockpit/3-official-images
branch
from
August 11, 2026 11:18
c64c16e to
a2327c2
Compare
croissanne
force-pushed
the
lucas/cockpit/3-official-images
branch
from
August 11, 2026 12:39
a2327c2 to
c2e4bdf
Compare
lucasgarfield
force-pushed
the
lucas/cockpit/3-official-images
branch
from
August 11, 2026 13:46
c2e4bdf to
9fdba7b
Compare
lucasgarfield
force-pushed
the
lucas/cockpit/3-official-images
branch
from
August 11, 2026 15:51
9fdba7b to
c64c16e
Compare
lucasgarfield
force-pushed
the
lucas/cockpit/3-official-images
branch
from
August 12, 2026 11:53
c64c16e to
8e43b8e
Compare
lucasgarfield
force-pushed
the
lucas/cockpit/3-official-images
branch
from
August 12, 2026 12:53
8e43b8e to
de6b452
Compare
The pull mutation's busy and error flags are hook-level, so switching to another image while a pull was in flight kept showing the pulling state on the newly selected image. Gate both flags on the mutation's originalArgs matching the current selection. Cache refreshes are unaffected: pull invalidates ImageExists per reference already.
The image-exists query result was served from the RTK Query cache, so removing a container outside the wizard (podman rmi) went unnoticed when the wizard was reopened. Pass refetchOnMountOrArgChange so the existence check re-runs podman whenever the image source section is shown; the wizard-level pull validation shares the same cache entries and picks up the fresh result.
Same staleness as the image existence check: logging out via the CLI went unnoticed because the auth status was served from the cache. Re-run the check whenever the image source section is shown.
Registry login is only needed to pull images, so drop the login-gated empty state and the "Login required" label. The image dropdown is now always shown; a logged-out user instead sees an inline info alert offering the registry login, and the pull buttons are disabled with an explanatory tooltip. When a selected image is missing from local storage, the pull validation now says how to resolve it: logged in, it asks for a pull; logged out, it points at the registry login. The auth status hook gets the same hosted-safe conditional export as the image existence check, since useImagePullValidation calls it unconditionally.
lucasgarfield
force-pushed
the
lucas/cockpit/3-official-images
branch
from
August 13, 2026 15:23
de6b452 to
fdc321a
Compare
Collaborator
Author
|
Replaced by #4756 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registry login is no longer required to browse official images — logged-out users see the dropdown with pull disabled, and existence/auth checks stop going stale.
Stack created with GitHub Stacks CLI • Give Feedback 💬